feat(o11y): introduce observability flags needed within the generator - #9052
Open
shivanee-p wants to merge 9 commits into
Open
feat(o11y): introduce observability flags needed within the generator#9052shivanee-p wants to merge 9 commits into
shivanee-p wants to merge 9 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for an enableTelemetryTracing option across the generator, schema, and client interface packages, including adding the option to ClientOptions and introducing an InternalTelemetry interface. Feedback suggests updating the parameter parsing in the generator to support both hyphenated and snake_case parameter names for consistency with other flags, and to only set the property to true when explicitly configured.
westarle
reviewed
Aug 3, 2026
shivanee-p
force-pushed
the
shivaneep-o11y-flag
branch
2 times, most recently
from
August 4, 2026 03:22
c7259a4 to
4159976
Compare
westarle
approved these changes
Aug 12, 2026
shivanee-p
force-pushed
the
shivaneep-o11y-flag
branch
from
August 14, 2026 20:55
77b4eaf to
048fff3
Compare
shivanee-p
force-pushed
the
shivaneep-o11y-flag
branch
from
August 14, 2026 22:54
a27b286 to
78c2295
Compare
shivanee-p
force-pushed
the
shivaneep-o11y-flag
branch
from
August 14, 2026 23:04
47c98d3 to
019323f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the o11y feature flag to
gapic-generator-typescript