impl(bigtable): make dynamic pool options available and update integration tests#16056
impl(bigtable): make dynamic pool options available and update integration tests#16056scotthart wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Bigtable client library to expose dynamic channel pool configuration options to users. By moving the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the InstanceChannelAffinityOption and DynamicChannelPoolSizingPolicy by moving their definitions from internal headers to google/cloud/bigtable/options.h within the experimental namespace, making these experimental channel pooling configurations publicly available. The changes also update internal code to reflect the new namespace and enhance the testing framework by adding variations to BUILD.bazel and modifying table_integration_test.cc to enable and test the dynamic channel pool feature via an environment variable. A critical issue was identified where the pool_size_increase_cooldown_interval member was inadvertently omitted from the DynamicChannelPoolSizingPolicy struct in options.h, which needs to be re-added to prevent compilation errors and ensure correct behavior.
f44e591 to
3d37c04
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16056 +/- ##
==========================================
+ Coverage 92.68% 92.69% +0.01%
==========================================
Files 2342 2343 +1
Lines 216537 216541 +4
==========================================
+ Hits 200700 200727 +27
+ Misses 15837 15814 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR enables instance bound connections with dynamic channel pools.
fixes #16035