Skip to content

impl(bigtable): make dynamic pool options available and update integration tests#16056

Open
scotthart wants to merge 2 commits intogoogleapis:mainfrom
scotthart:bigtable_dynamic_pool_integration_tests
Open

impl(bigtable): make dynamic pool options available and update integration tests#16056
scotthart wants to merge 2 commits intogoogleapis:mainfrom
scotthart:bigtable_dynamic_pool_integration_tests

Conversation

@scotthart
Copy link
Member

This PR enables instance bound connections with dynamic channel pools.

fixes #16035

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Mar 25, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Bigtable client library to expose dynamic channel pool configuration options to users. By moving the InstanceChannelAffinityOption and DynamicChannelPoolSizingPolicy to the public options.h header, it enables developers to configure instance-bound connections with dynamic channel pools. The changes also include updates to internal implementations and integration tests to support and validate this new configurability, allowing for more flexible connection management based on workload patterns.

Highlights

  • Public API Exposure: Moved InstanceChannelAffinityOption and DynamicChannelPoolSizingPolicy from internal headers to google/cloud/bigtable/options.h within the experimental namespace, making these dynamic channel pool configuration options publicly available.
  • Internal Code Updates: Updated internal implementations, including DynamicChannelPool and related tests, to reference the newly exposed experimental::DynamicChannelPoolSizingPolicy.
  • Enhanced Integration Testing: Modified integration tests to allow conditional enabling of dynamic channel pools via an environment variable, and updated Bazel build configurations to run tests with both static and dynamic channel pool settings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the InstanceChannelAffinityOption and DynamicChannelPoolSizingPolicy by moving their definitions from internal headers to google/cloud/bigtable/options.h within the experimental namespace, making these experimental channel pooling configurations publicly available. The changes also update internal code to reflect the new namespace and enhance the testing framework by adding variations to BUILD.bazel and modifying table_integration_test.cc to enable and test the dynamic channel pool feature via an environment variable. A critical issue was identified where the pool_size_increase_cooldown_interval member was inadvertently omitted from the DynamicChannelPoolSizingPolicy struct in options.h, which needs to be re-added to prevent compilation errors and ensure correct behavior.

@scotthart scotthart force-pushed the bigtable_dynamic_pool_integration_tests branch from f44e591 to 3d37c04 Compare March 25, 2026 17:38
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.69%. Comparing base (d60f99e) to head (bb3facd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16056      +/-   ##
==========================================
+ Coverage   92.68%   92.69%   +0.01%     
==========================================
  Files        2342     2343       +1     
  Lines      216537   216541       +4     
==========================================
+ Hits       200700   200727      +27     
+ Misses      15837    15814      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart marked this pull request as ready for review March 25, 2026 19:22
@scotthart scotthart requested a review from a team as a code owner March 25, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigtable: relocate DyanmicChannelPool related Options to the bigtable::experimental namespace

1 participant