chore: update abseil to 20260107.1#16054
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the project's dependency on the Abseil C++ library to version Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the abseil-cpp dependency version from 20250814.2 to 20260107.1 across MODULE.bazel, various Dockerfiles, and the doc/packaging.md file. The review comments suggest improving maintainability by avoiding hardcoded and duplicated version strings in Dockerfiles by using ARG and in documentation by using common references or variables where possible.
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ |
There was a problem hiding this comment.
The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.
2 participants
No description provided.