-
Notifications
You must be signed in to change notification settings - Fork 441
chore: update googleapis SHA circa 2026-02-02 #15926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PiperOrigin-RevId: 863524449
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the core Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the googleapis dependency to a newer SHA. The changes are mostly mechanical, including updated SHAs in build files, new proto definitions in .list files, and regenerated C++ client code. The changes appear to be correct and consistent with an automated dependency update. I have one comment on a potential issue in the newly generated code for the osconfig_agentendpoint service where a routing header might be missing.
| grpc::ClientContext& context, Options const& options, | ||
| google::cloud::osconfig::agentendpoint::v1::ReportVmInventoryRequest const& | ||
| request) { | ||
| SetMetadata(context, options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The x-goog-request-params header for routing is not being set for this RPC. Other RPCs in this service that use instance_id_token set it for routing. This seems like an oversight in the generated code and could lead to routing issues.
It should probably be set like this:
SetMetadata(context, options,
absl::StrCat("instance_id_token=",
internal::UrlEncode(request.instance_id_token()))); SetMetadata(context, options, absl::StrCat("instance_id_token=", internal::UrlEncode(request.instance_id_token())));
diegomarquezp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diegomarquezp reviewed 67 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scotthart).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15926 +/- ##
==========================================
+ Coverage 92.95% 92.96% +0.01%
==========================================
Files 2460 2460
Lines 228901 228901
==========================================
+ Hits 212781 212805 +24
+ Misses 16120 16096 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change is