Skip to content

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Feb 2, 2026

This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner February 2, 2026 16:00
@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the core googleapis dependency, incorporating new API definitions and expanding existing ones across multiple Google Cloud services. The changes ensure that the project's build configurations and client libraries are aligned with the latest proto definitions, leading to new API methods being exposed and existing documentation links being refreshed.

Highlights

  • Dependency Update: The googleapis dependency has been updated to a newer SHA (c0fcb35628690e9eb15dcefae41c651c67cd050b). This involves updating integrity hashes and strip prefixes in MODULE.bazel, bazel/workspace0.bzl, and cmake/GoogleapisConfig.cmake.
  • New API Definitions: Several new .proto files have been added across various Google Cloud services, indicating new or expanded API surfaces. These include backupvault_alloydb.proto for BackupDR, multiple new files for Dialogflow CX (e.g., code_block.proto, example.proto, playbook.proto), risk.proto for Grafeas, hsm_management.proto for KMS, host_group.proto for NetApp, vm_inventory.proto for OSConfig, and container_status.proto, instance.proto for Cloud Run.
  • Documentation Link Adjustments: Numerous @googleapis_reference_link comments in client header files (google/cloud/*/client.h) have been updated to reflect the new line numbers of the corresponding proto definitions, a direct consequence of the proto file changes.
  • New NetApp API Operations: The NetApp client now includes support for new operations such as RestoreBackupFiles, ListHostGroups, GetHostGroup, CreateHostGroup, UpdateHostGroup, and DeleteHostGroup, with corresponding implementations in internal decorators and connection classes.
  • New OSConfig Agent Endpoint API Operation: The OSConfig Agent Endpoint client now supports a new ReportVmInventory operation, including its connection, stub, and decorator implementations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the googleapis dependency to a newer SHA. The changes are mostly mechanical, including updated SHAs in build files, new proto definitions in .list files, and regenerated C++ client code. The changes appear to be correct and consistent with an automated dependency update. I have one comment on a potential issue in the newly generated code for the osconfig_agentendpoint service where a routing header might be missing.

grpc::ClientContext& context, Options const& options,
google::cloud::osconfig::agentendpoint::v1::ReportVmInventoryRequest const&
request) {
SetMetadata(context, options);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The x-goog-request-params header for routing is not being set for this RPC. Other RPCs in this service that use instance_id_token set it for routing. This seems like an oversight in the generated code and could lead to routing issues.

It should probably be set like this:

  SetMetadata(context, options,
              absl::StrCat("instance_id_token=",
                           internal::UrlEncode(request.instance_id_token())));
  SetMetadata(context, options, absl::StrCat("instance_id_token=", internal::UrlEncode(request.instance_id_token())));

Copy link
Collaborator

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomarquezp reviewed 67 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scotthart).

@scotthart scotthart enabled auto-merge (squash) February 2, 2026 16:49
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (dd670bd) to head (0f37a03).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15926      +/-   ##
==========================================
+ Coverage   92.95%   92.96%   +0.01%     
==========================================
  Files        2460     2460              
  Lines      228901   228901              
==========================================
+ Hits       212781   212805      +24     
+ Misses      16120    16096      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit 14c94b4 into googleapis:main Feb 2, 2026
61 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants