ci: use gha to get windows vcpkg working

[scotthart]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the continuous integration (CI) pipeline's ability to build opentelemetry-cpp using vcpkg on Windows environments within GitHub Actions. It involves a comprehensive update to the opentelemetry-cpp vcpkg port definition, including a new patch to resolve library linking issues. Additionally, CMake configurations have been standardized to use C++17, and specific Windows compatibility adjustments have been made to ensure a robust and consistent build experience for this critical dependency.

Highlights

• Vcpkg Port Update: The opentelemetry-cpp vcpkg port has been updated to version 1.23.0, introducing new features and dependencies for better integration.
• OpenTracing Link Fix: A new patch (fix-target_link.patch) was added to opentelemetry-cpp to correctly handle OpenTracing library linking, ensuring find_package is REQUIRED and providing an alias for static libraries.
• C++ Standard Enforcement: CMake configurations now explicitly enforce the C++17 standard (-DCMAKE_CXX_STANDARD=17) across relevant build processes, ensuring consistency.
• Windows Compatibility Fixes: Windows-specific build issues were addressed, including correcting path separators in VCPKG_OVERLAY_PORTS and adding #define NOMINMAX to prevent macro conflicts in curl_handle_factory_benchmark.cc.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/test-runner.yml
  • .github/workflows/windows-cmake.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the CI configuration, primarily to improve Windows builds using vcpkg. Key changes include updating the opentelemetry-cpp vcpkg port to a newer version, consistently setting the C++ standard to C++17, and adding a workaround for NOMINMAX on Windows.

My review identified a critical issue in ci/gha/builds/lib/cmake.sh where unescaped backslashes in a path will cause build failures. I also noted a minor redundancy in the opentelemetry-cpp/portfile.cmake where some CMake flags are specified twice. I've provided suggestions to address these points.

[gemini-code-assist]

The backslashes in this path are not escaped. When this line is interpreted by a shell like bash, the backslashes will act as escape characters and will be removed, resulting in a malformed path (cighabuildsvcpkg-overlays).

If backslashes are necessary for Windows, they must be escaped:

args+=("-DVCPKG_OVERLAY_PORTS=ci\\gha\\builds\\vcpkg-overlays")

However, CMake on Windows generally handles forward slashes correctly, which is more portable. It's recommended to use forward slashes unless there's a specific reason vcpkg requires backslashes here.

Suggested change

	args+=("-DVCPKG_OVERLAY_PORTS=ci\gha\builds\vcpkg-overlays")
	args+=("-DVCPKG_OVERLAY_PORTS=ci/gha/builds/vcpkg-overlays")

[gemini-code-assist]

These CMake options are redundant as they are already appended to FEATURE_OPTIONS on line 47. Since ${FEATURE_OPTIONS} is passed to vcpkg_cmake_configure, these lines can be removed to avoid duplication and improve clarity.

[codecov]

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.86%. Comparing base (74e98fc) to head (7d6bc89).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Files with missing lines	Patch %	Lines
...erator/internal/round_robin_decorator_generator.cc	0.00%	4 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           prepare-for-v3.0.0   #15921   +/-   ##
===================================================
  Coverage               92.85%   92.86%           
===================================================
  Files                    2343     2343           
  Lines                  216214   216254   +40     
===================================================
+ Hits                   200773   200816   +43     
+ Misses                  15441    15438    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.