This repository was archived by the owner on Mar 3, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 351
sample: delete samples/snippets directory #1964
Closed
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
92b42a1
Support the mTLS IAM domain for Certificate based Access
amtk3 af469a3
Update google/auth/iam.py
amtk3 94a0e77
Merge branch 'main' into support-mtls-iam-domain
chalmerlowe b52742b
updates handling of mtls and universe domain
chalmerlowe 64cd681
updates linting
chalmerlowe e9ffe54
Merge branch 'main' into support-mtls-iam-domain
chalmerlowe bfe7081
Merge branch 'main' into support-mtls-iam-domain
daniel-sanche e2e2b9b
Support an alternative env to decide if mtls should be enabled
amtk3 f540519
feat(iam): support an alternative env to decide if mtls should be ena…
amtk3 6a3bf26
feat: add fallback env vars for mTLS config
google-labs-jules[bot] 150511c
Merge pull request #3 from amtk3/mtls-env-vars-fallback-1336179603064…
amtk3 90793f1
Use "_mtls_helper" class
amtk3 3ae9e7a
Merge branch 'iam-mtls-alternative-env' into support-mtls-iam-domain
amtk3 7fdefea
Merge pull request #4 from amtk3/support-mtls-iam-domain
amtk3 471a0bc
Merge branch 'main' into iam-mtls-alternative-env
chalmerlowe 6995e43
Apply suggestion from @chalmerlowe
chalmerlowe f62279f
moves tests to a more appropriate file.
chalmerlowe 47015a8
removes no longer needed file.
chalmerlowe 2d7f263
updates linting
chalmerlowe d5694e9
samples: delete samples/snippets directory
chalmerlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -151,7 +151,14 @@ def _get_cert_config_path(certificate_config_path=None): | |
| if env_path is not None and env_path != "": | ||
| certificate_config_path = env_path | ||
| else: | ||
| certificate_config_path = CERTIFICATE_CONFIGURATION_DEFAULT_PATH | ||
| env_path = environ.get( | ||
| environment_vars.CLOUDSDK_CONTEXT_AWARE_CERTIFICATE_CONFIG_FILE_PATH, | ||
| None, | ||
| ) | ||
| if env_path is not None and env_path != "": | ||
| certificate_config_path = env_path | ||
| else: | ||
| certificate_config_path = CERTIFICATE_CONFIGURATION_DEFAULT_PATH | ||
|
|
||
| certificate_config_path = path.expanduser(certificate_config_path) | ||
| if not path.exists(certificate_config_path): | ||
|
|
@@ -452,13 +459,23 @@ def check_use_client_cert(): | |
| Returns: | ||
| bool: Whether the client certificate should be used for mTLS connection. | ||
| """ | ||
| use_client_cert = getenv("GOOGLE_API_USE_CLIENT_CERTIFICATE") | ||
| use_client_cert = getenv(environment_vars.GOOGLE_API_USE_CLIENT_CERTIFICATE) | ||
| if use_client_cert is None or use_client_cert == "": | ||
| use_client_cert = getenv( | ||
| environment_vars.CLOUDSDK_CONTEXT_AWARE_USE_CLIENT_CERTIFICATE | ||
| ) | ||
|
|
||
| # Check if the value of GOOGLE_API_USE_CLIENT_CERTIFICATE is set. | ||
| if use_client_cert: | ||
| return use_client_cert.lower() == "true" | ||
| else: | ||
| # Check if the value of GOOGLE_API_CERTIFICATE_CONFIG is set. | ||
| cert_path = getenv("GOOGLE_API_CERTIFICATE_CONFIG") | ||
| cert_path = getenv(environment_vars.GOOGLE_API_CERTIFICATE_CONFIG) | ||
| if cert_path is None: | ||
| cert_path = getenv( | ||
| environment_vars.CLOUDSDK_CONTEXT_AWARE_CERTIFICATE_CONFIG_FILE_PATH | ||
| ) | ||
|
Comment on lines
+473
to
+477
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This logic for determining cert_path = getenv(
environment_vars.GOOGLE_API_CERTIFICATE_CONFIG
) or getenv(
environment_vars.CLOUDSDK_CONTEXT_AWARE_CERTIFICATE_CONFIG_FILE_PATH
) |
||
|
|
||
| if cert_path: | ||
| try: | ||
| with open(cert_path, "r") as f: | ||
|
|
||
55 changes: 0 additions & 55 deletions
55
samples/cloud-client/snippets/authenticate_explicit_with_adc.py
This file was deleted.
Oops, something went wrong.
46 changes: 0 additions & 46 deletions
46
samples/cloud-client/snippets/authenticate_implicit_with_adc.py
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for determining
use_client_certcan be made more concise by using theoroperator.