feat: Add trust boundary support for external accounts. #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_build_trust_boundary_lookup_url(self): | ||
| credentials = self.make_credentials() | ||
| expected_url = "https://iamcredentials.googleapis.com/v1/locations/global/workforcePools/POOL_ID/allowedLocations" |
There was a problem hiding this comment.
Add few more cases:
- rep instead of global
- different universe
| assert credentials._build_trust_boundary_lookup_url() == expected_url | ||
|
|
||
| def test_build_trust_boundary_lookup_url_invalid_audience(self): | ||
| credentials = self.make_credentials(audience="invalid") |
There was a problem hiding this comment.
add cases with real looking url but not have expected pattern
| @@ -278,7 +278,7 @@ def _refresh_token(self, request): | |||
| self._source_credentials.token_state == credentials.TokenState.STALE | |||
| or self._source_credentials.token_state == credentials.TokenState.INVALID | |||
| ): | |||
| self._source_credentials.refresh(request) | |||
| self._source_credentials._refresh_token(request) | |||
There was a problem hiding this comment.
why do we need to get the turst boundary locations for source cred? It will be the outer (impersonated) cred that will be adding the headers for the API calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the trust boundary feature for external accounts (workforce and workload pool identity, and also authorized user)
Note: The design has changed since the first PR that implemented trust boundary for service accounts, and we are no longer required to send the allowed locations header to IAM or STS requests, only to the google API calls. You can review the most up to date design here: go/trust-boundaries-auth-sdk-v2