-
Notifications
You must be signed in to change notification settings - Fork 346
feat: Added Temporary token based authentication similar to cli --access-token-file #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Temporary token based authentication similar to cli --access-token-file #1467
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
…-access-token-file
…Chotaliya/google-auth-library-python into temporary_access_token_auth
|
I appreciate the time and effort invested into this PR. In looking it over, there are some issues that concern me. In light of the push to migrate this library to the google-cloud-python mono-repo we need to resolve all the PRs. I recommend that we close this PR (once the migration is complete, it might make sense to revisit this. For that reason, I will leave my thoughts below on what it would take to enable us to merge this PR). Logical Conflicts: The PR introduces a top-level import Error Handling: The implementation in Transport Agnosticism: The Missing Tests: There are no unit tests added for the new checker in Incomplete Logic: The PR assumes Type Hinting: The new method Docstrings: The docstring for Architecture: Validating credentials during the Critical Issues:
|
Fixes #1165
This features allows using access token in the sdk without having any of the GCP related credentials.
Example Usage:
gcloud auth print-access-token [email protected]export GOOGLE_TEMPORARY_ACCESS_TOKEN=token copied from aboveIt should work fine till the token is valid.