Use maven plugin to generate Client-Side CAB proto code. #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8154ea3c3c3126a1cf47e563b9b9e2f6b85c7f1a
lqiu96
reviewed
Jan 30, 2025
cab-token-generator/pom.xml
Outdated
| <version>0.6.1</version> | ||
| <configuration> | ||
| <protoSourceRoot>${project.basedir}/proto</protoSourceRoot> | ||
| <protocArtifact>com.google.protobuf:protoc:${project.protobuf.version}:exe:${os.detected.classifier}</protocArtifact> |
There was a problem hiding this comment.
Can we define a new maven property for the protoc version (i.e. something like project.protoc.version)? I would like to separate the Protoc and Protobuf-Java runtime to give us flexibility to move the runtime forward.
lqiu96
reviewed
Jan 30, 2025
Comment on lines
1
to
13
| // Copyright 2023 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. |
There was a problem hiding this comment.
To be safe, can the header be updated to match https://github.com/googleapis/google-auth-library-java/blob/main/java.header with the updated year? Same for the other proto files below?
lqiu96
reviewed
Jan 30, 2025
Change-Id: I2efb2fa0472e3af01a3955126cd27e37450ee95a
Change-Id: I87a5e073f16eac13ac74940bceca64fab21cee64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
protobuf-maven-pluginto automatically generate the protobuf Java code and remove the generated code.The version of protoc is determined by the
project.protobuf.versionand it's currently 3.25.5.Change-Id: I8154ea3c3c3126a1cf47e563b9b9e2f6b85c7f1a
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.