Skip to content

Conversation

@agrawalradhika-cell
Copy link
Contributor

The Python SDK will use a hybrid approach for mTLS enablement:

If the GOOGLE_API_USE_CLIENT_CERTIFICATE environment variable is set (either true or false or any value), the SDK will respect that setting. This is necessary for test scenarios and users who need to explicitly control mTLS behavior.
If the GOOGLE_API_USE_CLIENT_CERTIFICATE environment variable is not set, the SDK will automatically enable mTLS only if it detects Managed Workload Identity (MWID) or X.509 Workforce Identity Federation (WIF) certificate sources. In other cases where the variable is not set, mTLS will remain disabled.

** This change also adds unit test with respect to this change.

@agrawalradhika-cell agrawalradhika-cell requested review from a team as code owners November 20, 2025 04:56
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 20, 2025
Copy link

@andyrzhao andyrzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chingor13 chingor13 assigned daniel-sanche and unassigned chingor13 Nov 21, 2025
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2025
daniel-sanche
daniel-sanche previously approved these changes Dec 5, 2025
Copy link

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2025
@Linchin Linchin self-requested a review December 5, 2025 21:15
@daniel-sanche daniel-sanche merged commit a1fd6f3 into googleapis:main Dec 5, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants