Skip to content

Arrow functions, let/const, and cleanup #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2017
Merged

Arrow functions, let/const, and cleanup #732

merged 4 commits into from
Apr 27, 2017

Conversation

JustinBeckwith
Copy link
Contributor

This introduces let/const instead of var, moves to arrow functions in some cases, removes explicit 'use strict', and cleans up a few imports.

@JustinBeckwith JustinBeckwith self-assigned this Apr 26, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2017
@codecov-io
Copy link

Codecov Report

Merging #732 into master will decrease coverage by 0.08%.
The diff coverage is 94.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   79.58%   79.49%   -0.09%     
==========================================
  Files           8        6       -2     
  Lines         240      239       -1     
  Branches       53       53              
==========================================
- Hits          191      190       -1     
  Misses         30       30              
  Partials       19       19
Impacted Files Coverage Δ
lib/utils.ts 100% <ø> (ø) ⬆️
lib/generator_utils.ts 60% <ø> (ø) ⬆️
lib/apirequest.ts 97.33% <100%> (+0.03%) ⬆️
lib/googleauth.ts 100% <100%> (ø)
lib/googleapis.ts 78.18% <100%> (ø) ⬆️
lib/discovery.ts 67.64% <89.65%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e22af7...d6dbbe6. Read the comment docs.

@jmdobry
Copy link
Contributor

jmdobry commented Apr 26, 2017

Do you plan on switching to ES2015 classes, destructuring, etc. in a separate PR?

@JustinBeckwith
Copy link
Contributor Author

@jmdobry Yeah, a basic outline of my plan is in #503. After this, next step is es6 style imports and classes.

@jmdobry jmdobry merged commit 9c66166 into googleapis:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants