Skip to content

Update package.json #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Update package.json #699

merged 1 commit into from
Jan 30, 2017

Conversation

abruneau
Copy link
Contributor

@abruneau abruneau commented Jan 12, 2017

Fix package import with Typescript

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • npm test succeeds
  • Pull request has been squashed into 1 commit
  • I did NOT manually make changes to anything in apis/
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate JSDoc comments were updated in source code (if applicable)
  • Approprate changes to readme/docs are included in PR

Fix package import with Typescript
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 12, 2017
@codecov-io
Copy link

codecov-io commented Jan 12, 2017

Current coverage is 94.71% (diff: 100%)

Merging #699 into master will not change coverage

@@             master       #699   diff @@
==========================================
  Files            20         20          
  Lines          1382       1382          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1309       1309          
  Misses           73         73          
  Partials          0          0          

Powered by Codecov. Last update 482b7f7...20d4ed2

@ace-n
Copy link
Contributor

ace-n commented Jan 13, 2017

(FYI: this is intended to fix #503)

@jmdobry jmdobry self-requested a review January 29, 2017 07:20
Copy link
Contributor

@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but looks like you need to sign the CLA.

@abruneau
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 30, 2017
@jmdobry jmdobry merged commit ade0190 into googleapis:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants