Skip to content

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Mar 30, 2018

It can always be better, but this is a first crack at closing the loop on #503. This makes some tradeoffs to avoid breaking the API. Thoughts appreciated :)

Note: all the good stuff is at the end. You can safely ignore generated file changes.

Resolves #503.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2018
@JustinBeckwith JustinBeckwith merged commit 26e3a15 into googleapis:master Apr 2, 2018
@andrelaszlo
Copy link
Contributor

andrelaszlo commented Apr 17, 2018

@JustinBeckwith This is cool! How can I use this in my code? For example:

  async listEvents(...): Promise<Schema$Event[]> { ... }

But how do I get the compiler to recognize Schema$Event? I could use triple-slash directives/reference path or an ugly import (probably something like import { Schema$Event } from '../../node_modules/googleapis/build/src/apis/calendar/v3.d'; in my case).

Is there a cleaner way?

@JustinBeckwith
Copy link
Contributor Author

Good point! I am working on a fix to make those interfaces a little more visible as part of #1112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants