Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Nov 27, 2025

We should ensure that generated code is formatted correctly, rather than relying on external code formatting which increases the overall generation time.

This PR removes code formatting as a separate step for noxfile.py. There were only 3 changes in the file needed to address formatting issues.

We already have a goldens-lint check which checks that the code is formatted properly. This PR avoid the extra step of formatting noxfile.py prior to running the lint check.

IOW, the blacken nox session no longer touches noxfile.py

run: |
nox -f tests/integration/goldens/asset/noxfile.py -s mypy-${{ env.LATEST_STABLE_PYTHON }} blacken lint
nox -f tests/integration/goldens/credentials/noxfile.py -s mypy-${{ env.LATEST_STABLE_PYTHON }} blacken lint
nox -f tests/integration/goldens/eventarc/noxfile.py -s mypy-${{ env.LATEST_STABLE_PYTHON }} blacken lint
nox -f tests/integration/goldens/logging/noxfile.py -s mypy-${{ env.LATEST_STABLE_PYTHON }} blacken lint
nox -f tests/integration/goldens/redis/noxfile.py -s mypy-${{ env.LATEST_STABLE_PYTHON }} blacken lint

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Nov 27, 2025
@parthea parthea force-pushed the remove-formatting-for-noxfile.py branch from 485d855 to 3698497 Compare November 27, 2025 16:07
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. size: m Pull request size is medium. and removed size: m Pull request size is medium. size: xs Pull request size is extra small. labels Nov 27, 2025
@parthea parthea marked this pull request as ready for review November 27, 2025 19:01
@parthea parthea requested a review from a team as a code owner November 27, 2025 19:01
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 27, 2025
@parthea parthea force-pushed the remove-formatting-for-noxfile.py branch 3 times, most recently from b9cd940 to 998a96a Compare November 27, 2025 20:24
@parthea parthea force-pushed the remove-formatting-for-noxfile.py branch from 998a96a to 12878e4 Compare November 27, 2025 20:27
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants