feat: Add support for Python 3.14 #2451
Open
+54
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
added
the
status: blocked
vchudnov-g
reviewed
Oct 6, 2025
| DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1] | ||
| # TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450): | ||
| # Add tests for Python 3.15 alpha1 | ||
| # https://peps.python.org/pep-0790/ |
There was a problem hiding this comment.
Why do we need this TODO here? The nox tests are parametrized below, so by changing the variables with the Python versions above, we can control what gets tested. I'd remove this TODO.
| ] | ||
|
|
||
| DEFAULT_PYTHON_VERSION = ALL_PYTHON[-2] | ||
| DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1] |
There was a problem hiding this comment.
Rather than changing the subscripts as new stable vs prerelease versions are release, let's just be explicit for now, as in the GitHub tests.yaml
Suggested change
| DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1] | |
| DEFAULT_PYTHON_VERSION = "3.14" | |
| PREVIEW_PYTHON_VERSION = "3.15" # later, once the preview is released. |
What I think could be even better long-term (outside the scope of this PR!) is to query something to determine the latest stable and preview version of Python so the tests adapt automatically. But that's a separate discussion/investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.14 release is expected on 2025-10-07
https://peps.python.org/pep-0745/
This is blocked on stable support for 3.14 in Github actions
https://github.com/googleapis/gapic-generator-python/actions/runs/18100235130/job/51501066926?pr=2451