feat: check Python and dependency versions in generated GAPICs #2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both the package dependency and the Python run-time checks depend on googleapis/python-api-core#832 |
product-auto-label
bot
added
size: m
vchudnov-g
commented
Aug 1, 2025
| return parse_version(version_string) | ||
|
|
||
| try: | ||
| _dependency_package = "google.protobuf" |
There was a problem hiding this comment.
Is this the correct package name? It falls through to the except clause for me when I run the integration tests. Do I need to create a real GAPIC to test this properly?
|
This PR will now do basic checks even if There are still some presubmit failures that I will continue investigating. |
vchudnov-g
force-pushed
the
python-version-support-check
branch
2 times, most recently
from
dce9bdf to
8645ead
Compare
vchudnov-g
force-pushed
the
python-version-support-check
branch
from
aa6c360 to
34eb7ab
Compare
vchudnov-g
force-pushed
the
python-version-support-check
branch
11 times, most recently
from
7db28d8 to
a4eb323
Compare
vchudnov-g
added
the
do not merge
|
Do not merge yet while I work out the final details of this initial implementation and we get approval on the design. (I'm expecting pre-submits to pass now.) |
vchudnov-g
added
the
owlbot:run
The preferred method is still to sue the code in api_core, but we have a (repetitive) fallback in case users haven't installed the new version that implements that functionality.
vchudnov-g
force-pushed
the
python-version-support-check
branch
from
a4eb323 to
a58ed35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to generated GAPICs to emit the appropriate usage warnings (most prominently, deprecation messages) for unsupported Python runtime versions and dependency versions.
The intent is that before we stop allowing some old versions of a package dependency, we'll have at least one release that adds a warning saying those versions of the dependency are deprecated, before we actually disallow those versions of the dependency in future versions of the GAPICs.
For Python run-times, once we depend on
google.api_coreafter the run-time checks have been implemented (in googleapis/python-api-core#832), these usage/deprecation warnings will be automatic. All we need to do is update the dates for (future) Python versions hard-coded therein.