Skip to content

Conversation

@guangstick
Copy link

@guangstick guangstick commented Mar 14, 2023

fix: set proper ttl in createsnapshot

ttl was not added to the expiration time and the Now ts was sent to the server. This leads to errors like "Expire time must be at least 6h from the time the backup was started, which should be XXX, but got XXXX"

@google-cla
Copy link

google-cla bot commented Mar 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@guangstick guangstick changed the title fix ttl in createsnapshot fix: set proper ttl in createsnapshot Mar 14, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Mar 14, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

ttl was not added to the expiration time and the Now ts was sent to the server. This leads to errors like "Expire time must be at least 6h from the time the backup was started, which should be XXX, but got XXXX"
@guangstick
Copy link
Author

@triplequark @igorbernstein2 @telpirion friendly ping mind taking a look at this one-liner PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant