Switch from trybuild to ui-test
#2801
Conversation
…ng imports This change fixes the "module `macros` is private" error in `tests/ui-nightly/invalid-impls/invalid-impls.rs` by: 1. Replacing `use zerocopy::*` with `pub use zerocopy::*` to ensure necessary items are visible to the included macros. 2. Adding a local `pub mod util` which shadows `zerocopy::util` and provides a `pub mod macros` containing a `pub(crate)` re-export of `__unsafe`. This ensures that the `unsafe_impl!` macro (which calls `crate::util::macros::__unsafe()`) resolves to the local, accessible definition rather than the private one in `zerocopy`. 3. Updating `.stderr` files by running tests with `--bless` to reflect the resolved errors (confirming the fix works and only expected failures remain).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
joshlf
changed the title
invalid-impls test error by re-exporting __unsafe and adjusting importstrybuild to ui-test
Merged changes from main. Fixed `invalid-impls.rs` test error "module `macros` is private" by locally re-exporting `__unsafe` as `pub(crate)` and adjusting imports to avoid ambiguity with `zerocopy::util`. Updated `.stderr` files to match `ui_test` output.
1 participant
This PR does not migrate zerocopy-derive's tests – that will be done in a follow-up PR.
Makes progress on #187
PR created automatically by Jules for task 8395116984462173372 started by @joshlf