Add regression test for suppressing private_bounds lint in KnownLayout derive
#2791
Conversation
This commit suppresses the `private_bounds` lint on the `__ZerocopyKnownLayoutMaybeUninit` struct generated by `#[derive(KnownLayout)]`. This lint can be falsely triggered when the derive macro is used on a public struct within a `macro_rules!` macro, where the generated code refers to private types (field indices) that are technically "more private" than the public struct, even though they are in the same module scope. Fixes #2177.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 20 20
Lines 5450 5450
=======================================
Hits 4804 4804
Misses 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit suppresses the `private_bounds` lint on the `__ZerocopyKnownLayoutMaybeUninit` struct generated by `#[derive(KnownLayout)]`. This lint can be falsely triggered when the derive macro is used on a public struct within a `macro_rules!` macro, where the generated code refers to private types (field indices) that are technically "more private" than the public struct, even though they are in the same module scope. Fixes #2177.
joshlf
changed the title
private_bounds lint in KnownLayout deriveprivate_bounds lint in KnownLayout derive
1 participant
We emit a
private_boundslint inKnownLayoutderive to fix false positives when used inmacro_rules!. This PR adds a regression test inzerocopy-derive/tests/hygiene.rs.Closes #2177
PR created automatically by Jules for task 11697562419254082005 started by @joshlf