Skip to content

Loosen --cfg zerocopy_derive_union_into_bytes #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 4, 2024

Permit it to be passed either when compiling zerocopy-derive or when compiling the user's crate. This makes the --cfg play more nicely with different build systems.

Makes progress on #1792

Permit it to be passed either when compiling zerocopy-derive or when
compiling the user's crate. This makes the --cfg play more nicely with
different build systems.

Makes progress on #1792
@joshlf joshlf requested a review from jswrenn October 4, 2024 15:44
@joshlf joshlf enabled auto-merge October 4, 2024 15:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.40%. Comparing base (d204727) to head (cab5024).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1819   +/-   ##
=======================================
  Coverage   87.40%   87.40%           
=======================================
  Files          16       16           
  Lines        5994     5994           
=======================================
  Hits         5239     5239           
  Misses        755      755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 733db7f Oct 4, 2024
87 checks passed
@joshlf joshlf deleted the union-into-bytes-cfg branch October 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants