Support tail call in the WASM interpreter #514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouwfang
changed the title
|
Thanks for the PR, but this is implementing tail-call optimization for the WASM byte code. What we want is tail-call optimization for the WASM interpreter (thus TCO in Rust). Note that there's a tail-call proposal for WASM that is almost finished: https://github.com/WebAssembly/tail-call. We might want to implement it at some point, but that's not a priority and not useful for #46. I'm closing as this is not a direction we want to go now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd just like to get some early feedback. I guess we probably want to preprocess/cache the detection of tail call, otherwise the overhead of
is_tail_call()may be larger than the benefits. WDYT? Thanks.#46