Add simple iOS app with libskia bindings for both simulator and arm64 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jun 17, 2020
| // | ||
| // Created by Jim Sproch on 6/9/20. | ||
| // Copyright © 2020 Jim Sproch. All rights reserved. | ||
| // |
There was a problem hiding this comment.
replace the copyrights with this:
// Copyright 2020 Google LLC. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Hixie
reviewed
Jun 17, 2020
Hixie
reviewed
Jun 17, 2020
Hixie
reviewed
Jun 17, 2020
Co-authored-by: Ian Hickson <[email protected]>
Hixie
reviewed
Jun 17, 2020
Co-authored-by: Ian Hickson <[email protected]>
Co-authored-by: Ian Hickson <[email protected]>
Co-authored-by: Ian Hickson <[email protected]>
|
You have a typo in the project name ("WOrld"), dunno if you care. LGTM with the copyright updates. |
|
Yeah, I noticed, don't care, this project will go away soon-ish anyway once we get the KMP version up and running. |
|
Should we land this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.