Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This proposal corrects the requirements for
min_transfer_time, making the field forbidden when transfers are not possible (transfer_type=3) or are in-seat transfers (transfer_type=4).Describe the Problem
min_transfer_timeis optional for all transfers wheretransfer_typeis not2. However,transfer_type=3and4are respectively "no transfers possible" and "in-seat transfer", which cannot be associated with any minimum time window.Proposed Solution
Forbid
min_transfer_timewhen transfers are not possible (transfer_type=3) or are in-seat transfers (transfer_type=4).Type of change
GTFS Schedule
Proposed Discussion Period
We will leave this PR open one week for discussion, one week for review (minimum per governance). Then we will raise a vote to adopt this fix.
Proposal Update Tracker
Checklist