This repository was archived by the owner on Oct 14, 2021. It is now read-only.
Run clippy on all the code #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already one incompatible change since 0.2 so the next version has to be 0.3.0. The current PR applying clippy fixes is also bringing some possible incompatibility. This also remove the version in between crate. It seems like we need to set this one only during release.
This is a breaking change.
This seems to be no longer needed.
This way we can run clippy only this module without running it on the grammar module itself.
|
Humm travis is breaking for all nightly build, there might be an issue with nightly builds... |
|
Ok the failures are due to rust-lang/rust#57488 So I'll just wait until it is fixed to move forward with this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch brings at least one bug fix and 2 incompatible changes thus bumping the version to 0.3