-
Notifications
You must be signed in to change notification settings - Fork 29
Implement ubrk.h #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ubrk.h #170
Conversation
Minor thing: I noticed that when the
|
You will note that elsewhere I use |
Thanks. Updated in d1876d5. |
I'm now looking at this PR. |
I found a couple of broken links in the doc comments. Fixed in 1932074. |
@filmil I appreciate the review. I believe I have addressed your feedback if you don't mind taking another look. |
Thank you for making the changes, I'll take a look as soon as able, but at the moment it seems will need to happen tomorrow. |
Re-reviewing now. |
Thank you for your patience for the review. This is now approved. |
Adds bindings for
ubrk.h
Closes #166
API
ubrk_close
impl Drop
ubrk_next
impl Iterator
ubrk_countAvailable
count_available_locales
ubrk_getAvailable
get_available_locale_at
ubrk_open
try_new
,try_new_ustring
ubrk_openRules
try_new_rules
,try_new_rules_ustring
ubrk_openBinaryRules
try_new_binary_rules
,try_new_binary_rules_ustring
ubrk_getBinaryRules
get_binary_rules
ubrk_safeClone
safe_clone
ubrk_setText
set_text
,set_text_ustring
ubrk_setUText
ubrk_refreshUText
ubrk_previous
previous
ubrk_current
current
ubrk_preceding
preceding
ubrk_following
following
ubrk_first
first
ubrk_last
last_boundary
2ubrk_isBoundary
is_boundary
ubrk_getLocaleByType
get_locale_by_type
ubrk_getRuleStatus
get_rule_status
ubrk_getRuleStatusVec
get_rule_status_vec
1 In light of #6 and the existing UText implementation, it made sense to leave these out for now.
2 The Rust
Iterator
trait already provides alast()
method, so I had to name this differently in order to avoid a conflict.