Add some minimal support for PEP 612 in type stubs. #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytype will gracefully fall back to Any when typing.ParamSpec or typing.Concatenate is used as the first argument to a Callable in a type stub, allowing typeshed to start using most of PEP 612. Custom generic classes parameterized with a ParamSpec are still not supported. pytype was reporting weird [bad-unpacking] errors in parser.py, so I kept adding ast3.AST annotations until they went away. I also fixed a bug in PrintVisitor that caused it to print typing_extensions imports as aliases rather than imports. For #786. PiperOrigin-RevId: 366342708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytype will gracefully fall back to Any when typing.ParamSpec or
typing.Concatenate is used as the first argument to a Callable in a type stub,
allowing typeshed to start using most of PEP 612. Custom generic classes
parameterized with a ParamSpec are still not supported.
pytype was reporting weird [bad-unpacking] errors in parser.py, so I kept
adding ast3.AST annotations until they went away.
I also fixed a bug in PrintVisitor that caused it to print typing_extensions
imports as aliases rather than imports.
For #786.
PiperOrigin-RevId: 366342708