Skip to content

Conversation

@jess-lowe
Copy link
Contributor

NVD Output Changes:

  • Updates the NVD conversion to start outputting OSV records instead of PackageInfo
  • Changes the output location of NVD to no longer be in the 'parts' directory

combine-to-osv changes:

  • reads in two file paths for NVD OSV data and CVE5 OSV data
  • lists CVEIDs of Alpine and debian vulns and generates the 'upstream' records for them too so they still have an upstream,
  • somewhat intelligently tries to combine data between the records, with a bias toward the CVE5 conversion.
  • outputs the files.

@jess-lowe jess-lowe requested review from another-rex and michaelkedar and removed request for another-rex October 1, 2025 06:23
if nvdRanges, ok := nvdRepoMap[repo]; ok {
var newAffectedRanges []osvschema.Range

// Found a match. If NVD has more ranges, use its ranges.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern here as above, is this the correct assumption? What if cve5 has different ranges?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to look at improving and handling this in a future PR. For now, I just want to have some level of merging intelligence, so we can start populating the records, and will work on improving it later.

@jess-lowe jess-lowe requested a review from another-rex October 2, 2025 05:57
Copy link
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jess-lowe jess-lowe requested a review from another-rex October 3, 2025 01:25
Copy link
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jess-lowe jess-lowe merged commit 5afab6f into google:master Oct 7, 2025
16 checks passed
@jess-lowe jess-lowe deleted the feat/combine-2-osv branch October 13, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants