-
Notifications
You must be signed in to change notification settings - Fork 252
feat: rework combine-to-osv to begin to combine NVD and CVE5 OSV records #4086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit c56e9d5.
| if nvdRanges, ok := nvdRepoMap[repo]; ok { | ||
| var newAffectedRanges []osvschema.Range | ||
|
|
||
| // Found a match. If NVD has more ranges, use its ranges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same concern here as above, is this the correct assumption? What if cve5 has different ranges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to look at improving and handling this in a future PR. For now, I just want to have some level of merging intelligence, so we can start populating the records, and will work on improving it later.
another-rex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
another-rex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
NVD Output Changes:
PackageInfocombine-to-osvchanges: