Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarantool: use libfuzzer options #12985

Merged

Conversation

ligurio
Copy link
Contributor

@ligurio ligurio commented Jan 27, 2025

If the dict filename is the same as your target binary name
(i.e. %fuzz_target%.dict), it will be automatically used.
If the name is different (e.g. because it is shared by several
targets), specify this in .options file.

  1. https://google.github.io/oss-fuzz/getting-started/new-project-guide/#dictionaries

Needed for tarantool/tarantool#10911

Copy link

ligurio has previously contributed to projects/tarantool. The previous PR was #12859

If the dict filename is the same as your target binary name
(i.e. `%fuzz_target%.dict`), it will be automatically used.
If the name is different (e.g. because it is shared by several
targets), specify this in `.options` file.

1. https://google.github.io/oss-fuzz/getting-started/new-project-guide/#dictionaries

Needed for tarantool/tarantool#10911
@ligurio ligurio force-pushed the ligurio/gh-xxxx-use-libfuzzer-options branch from 6bb9951 to 688bd27 Compare January 27, 2025 18:34
@ligurio
Copy link
Contributor Author

ligurio commented Jan 29, 2025

@DavidKorczynski ok to merge?

@ligurio
Copy link
Contributor Author

ligurio commented Jan 30, 2025

@DavidKorczynski please review

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- fwiw I'm not sure what happens if you both have a dict named according to the target and also a dict specified in the options file. I assume both will be used for the fuzzing, but I'm not certain.

@DavidKorczynski DavidKorczynski merged commit 2f6dd58 into google:master Jan 30, 2025
15 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-use-libfuzzer-options branch January 30, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants