Update thrift build script

[fishy]

This needs to be merged after 1 to keep thrift working.

1 is needed because the current test code of thrift is actually broken with go 1.21, in order to fix the breakage some changes to go modules are needed, and the same changes need to be applied here as well to keep oss-fuzz working with thrift.

[github-actions]

fishy is a new contributor to projects/thrift. The PR must be approved by known contributors before it can be merged. The past contributors are: catenacyber

[DavidKorczynski]

This needs to be merged after apache/thrift#2886 to keep thrift working.

Converting this to draft while we're waiting for this

[catenacyber]

Good for me.

But there may be another issue with the build in the previous make command

[fishy]

apache/thrift#2886 is merged now.

[catenacyber]

hey @DavidKorczynski could you approve to run CI workflow ?

[DavidKorczynski]

hey @DavidKorczynski could you approve to run CI workflow ?

Done!

[catenacyber]

@fishy could you rebase and force-push now that apache/thrift#2899 was merged ?
So we will check the build is indeed fixed

[fishy]

@fishy could you rebase and force-push now that apache/thrift#2899 was merged ?
So we will check the build is indeed fixed

will do that on Friday, currently on vacation without laptop.

[fishy]

@catenacyber done.

[catenacyber]

And build fixed :-)

[cfriedt]

@fishy - can you elaborate a bit more on what was broken here that needed to be fixed? I would like to retry removing substituting something for boost::numeric_cast again, if possible, and would like to make sure that nothing was missing.

[fishy]

@fishy - can you elaborate a bit more on what was broken here that needed to be fixed? I would like to retry removing substituting something for boost::numeric_cast again, if possible, and would like to make sure that nothing was missing.

@cfriedt The oss-fuzz directory under thrift (https://github.com/apache/thrift/tree/master/lib/go/test/fuzz) first runs thrift compiler to generate 2 go libraries, and the actual test code depends on these 2 go libraries. We used to (before this PR) generate 2 go modules from these 2 go libraries for the test code to use, but this PR (and the thrift PR) changed them to be just part of the go module under lib/go/test/fuzz instead.

[cfriedt]

@fishy - even with the header added to Makefile.am, were there fuzz tests failing? Would be good to reproduce the expected results with my changes.

[fishy]

@cfriedt oh I never knew where to check the states/results of oss-fuzz. I just asked @catenacyber to check them for me.