Skip to content

Comments

Extract inventory build logic to a standalone function#261

Closed
AlexBasinov wants to merge 7 commits intogoogle:masterfrom
AlexBasinov:inventory-file
Closed

Extract inventory build logic to a standalone function#261
AlexBasinov wants to merge 7 commits intogoogle:masterfrom
AlexBasinov:inventory-file

Conversation

@AlexBasinov
Copy link
Collaborator

Extract the inventory file creation logic from the main install-oracle.sh script into a standalone build_inventory_file() function. This function now resides in its own standalone file to allow for potential reuse by other shell scripts. The original Bash code was copied with slight refactoring to improve readability and make the control flow easier to understand.

Internal bug: b/416300768

Testing:

@AlexBasinov AlexBasinov requested a review from mfielding June 10, 2025 19:26
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexBasinov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlexBasinov
Copy link
Collaborator Author

/test all

@AlexBasinov
Copy link
Collaborator Author

/test oracle-toolkit-install-free-edition-on-gcp oracle-toolkit-install-data-guard-on-gcp

@AlexBasinov
Copy link
Collaborator Author

/test oracle-toolkit-install-free-edition-on-gcp oracle-toolkit-install-data-guard-on-gcp

@AlexBasinov
Copy link
Collaborator Author

/test oracle-toolkit-install-free-edition-on-gcp oracle-toolkit-install-data-guard-on-gcp

@google-oss-prow
Copy link

@AlexBasinov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
oracle-toolkit-install-single-instance-on-bms a651ad8 link true /test oracle-toolkit-install-single-instance-on-bms
oracle-toolkit-install-rac-on-bms a651ad8 link true /test oracle-toolkit-install-rac-on-bms
oracle-toolkit-install-free-edition-on-gcp 6081c7b link true /test oracle-toolkit-install-free-edition-on-gcp
oracle-toolkit-install-data-guard-on-gcp 6081c7b link true /test oracle-toolkit-install-data-guard-on-gcp
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant