Extract inventory build logic to a standalone function#261
Extract inventory build logic to a standalone function#261AlexBasinov wants to merge 7 commits intogoogle:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexBasinov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5173639 to
364539c
Compare
f550802 to
a651ad8
Compare
|
/test all |
|
/test oracle-toolkit-install-free-edition-on-gcp oracle-toolkit-install-data-guard-on-gcp |
|
/test oracle-toolkit-install-free-edition-on-gcp oracle-toolkit-install-data-guard-on-gcp |
|
/test oracle-toolkit-install-free-edition-on-gcp oracle-toolkit-install-data-guard-on-gcp |
|
@AlexBasinov: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Extract the inventory file creation logic from the main install-oracle.sh script into a standalone build_inventory_file() function. This function now resides in its own standalone file to allow for potential reuse by other shell scripts. The original Bash code was copied with slight refactoring to improve readability and make the control flow easier to understand.
Internal bug: b/416300768
Testing: