Add travis and appveyor for prebuilding binaries #72
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| // Get the version of the library; | ||
| const pkg = require(path.resolve(__dirname, "..", "package.json")); | ||
| const packageVersion = pkg.version; | ||
| const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download"; |
There was a problem hiding this comment.
Url in this line needs to be adjusted to this repository.
There was a problem hiding this comment.
Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.
|
This is really great - thank you! Apologies for the lag on the review. I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy. |
| before_install: | ||
| - npm install -g yarn | ||
| - if [ $TRAVIS_OS_NAME == "linux" ]; then | ||
| export CC="gcc-7"; |
There was a problem hiding this comment.
Can you just specify "gcc"? These should be symlink'd on linux.
| // Get the version of the library; | ||
| const pkg = require(path.resolve(__dirname, "..", "package.json")); | ||
| const packageVersion = pkg.version; | ||
| const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download"; |
There was a problem hiding this comment.
Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.
3 participants
This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.
I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.
This change is