Gracefully handle empty output from vswhere.exe
#1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up commit to my previous commit [1], which started using 'vswhere.exe' to locate 'vcvarsall.bat' as discussed in google#1057. One thing I overlooked is that 'vswhere.exe' could return an empty result even when the exitcode is ERROR_SUCCESS. With this commit such a case will be gracefully handled. This is also a preparation to support ARM64 build on Windows (google#1130). [1]: ace3145
yukawa
force-pushed
the
gyp_win_arm64_3
branch
from
471b6ba to
89d4ee4
Compare
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up commit to my previous commit (ace3145), which started using 'vswhere.exe' to locate
vcvarsall.batas discussed in #1057.One thing I overlooked is that
vswhere.execould return an empty result even when the exitcode isERROR_SUCCESS. With this commit such a case will be gracefully handled.This is also a preparation to support ARM64 build on Windows (#1130).
Issue IDs
vswhereto find Visual C++ in Windows #1057Steps to test new behaviors (if any)