Fix clang thread-safety-pointer warnings #1270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang's -Wthread-safety-pointer warnings will become part of -Wthread-safety in
some future release. Add missing annotations for functions that pass the
address of guarded members. No functional change. Fixes the following warnings:
util/cache.cc:220:17: warning: passing pointer to variable 'in_use_' requires holding mutex 'mutex_' [-Wthread-safety-pointer]
220 | LRU_Append(&in_use_, e);
| ^
util/cache.cc:235:17: warning: passing pointer to variable 'lru_' requires holding mutex 'mutex_' [-Wthread-safety-pointer]
235 | LRU_Append(&lru_, e);
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
fanquake
added a commit
to bitcoin-core/leveldb-subtree
that referenced
this pull request
May 29, 2025
7daf4ed Fix clang thread-safety-pointer warnings (Cory Fields) Pull request description: This prevents a warning in an upcoming version of clang which will turn this on for us. Submitted upstream: google#1270 Clang's `-Wthread-safety-pointer` warnings will become part of `-Wthread-safety` in some future release. Add missing annotations for functions that pass the address of guarded members. No functional change. Fixes the following warnings: ```bash util/cache.cc:220:17: warning: passing pointer to variable 'in_use_' requires holding mutex 'mutex_' [-Wthread-safety-pointer] 220 | LRU_Append(&in_use_, e); | ^ util/cache.cc:235:17: warning: passing pointer to variable 'lru_' requires holding mutex 'mutex_' [-Wthread-safety-pointer] 235 | LRU_Append(&lru_, e); ``` ACKs for top commit: davidgumberg: Tested and review ACK 7daf4ed fanquake: ACK 7daf4ed Tree-SHA512: 5804c6fa915006b6fa75c6e31424058ddc5c5932ba126160aaf518325f04d158aef3e44c250e6b2edbd91aaf80a73f0dd48b367c8305ecaec92a088525d620d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang's
-Wthread-safety-pointerwarnings will become part of-Wthread-safetyin some future release. Add missing annotations for functions that pass the address of guarded members. No functional change. Fixes the following warnings: