Repository navigation
Conversation
std.jsonnet.h was generated by building to_c_array and running it on std.jsonnet. When cross-compiling, to_c_array is built for the target and cannot run on the build machine, so the build fails. Generate the header with a small script run through cmake -P at build time. It writes the same comma-separated, NUL-terminated byte list, as hex literals, and works the same for native and cross builds. The CMake build no longer needs the to_c_array target. to_c_array.cpp stays because the Makefile still uses it. Assisted-by: Claude Code:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative version of #1344 inspired by the Gemini review feedback. Unlike that version, this version doesn't only affect the cross-compilation branch, but all CMake builds (this is why I didn't update 1344 with this version, as I can understand if you'd prefer not to change all branches).