Improve performance of escapeStringBash and escapeStringDollars

google · Apr 8, 2024 · 9d58b57 · 9d58b57
1 parent 4e7678a
commit 9d58b57
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/stdlib/std.jsonnet b/stdlib/std.jsonnet
@@ -1005,21 +1005,11 @@ limitations under the License.
 
   escapeStringBash(str_)::
     local str = std.toString(str_);
-    local trans(ch) =
-      if ch == "'" then
-        "'\"'\"'"
-      else
-        ch;
-    "'%s'" % std.join('', [trans(ch) for ch in std.stringChars(str)]),
+    "'%s'" % std.strReplace(str, "'", "'\"'\"'"),
 
   escapeStringDollars(str_)::
     local str = std.toString(str_);
-    local trans(ch) =
-      if ch == '$' then
-        '$$'
-      else
-        ch;
-    std.foldl(function(a, b) a + trans(b), std.stringChars(str), ''),
+    std.strReplace(str, '$', '$$'),
 
   local xml_escapes = {
     '<': '&lt;',