Add API and launcher for NonEditableBasicTextField #2395
Conversation
| import androidx.compose.ui.text.input.VisualTransformation | ||
|
|
||
| /** | ||
| * This is a wrapper for [BasicTextField] that when clicked launches the keyboard. It cannot be |
There was a problem hiding this comment.
Need to improve these, but maybe wait until API is settled
oas004
force-pushed
the
non-editable-basic-text-field
branch
from
5835a3c to
fee27a5
Compare
|
|
||
| override fun parseResult(resultCode: Int, intent: Intent?): Result { | ||
| return if (resultCode == RESULT_OK) { | ||
| val resultText = intent?.extras?.getString("result_text") |
There was a problem hiding this comment.
I think it works, it's just that it's overridden by the BasicTextField implementation. Maybe using that wasn't such a good idea 🤔
oas004
force-pushed
the
non-editable-basic-text-field
branch
from
fee27a5 to
71ae7e0
Compare
oas004
force-pushed
the
non-editable-basic-text-field
branch
from
71ae7e0 to
2bd4ce7
Compare
| }, | ||
| value = value, | ||
| onValueChange = {}, | ||
| enabled = false, |
There was a problem hiding this comment.
This made it work since its suppressing the BasicTextField, but it feels quite hacky, maybe not the solution we want to go for I guess 😅
There was a problem hiding this comment.
What was not working before disabling the component?
There was a problem hiding this comment.
Before doing this, I think the BasicTextField was interfering (just my assumption). The text was not able to update correctly
| onTextChanged(it.text) | ||
| } | ||
| } | ||
| val keyboardIntent = Intent("com.google.android.wearable.action.LAUNCH_KEYBOARD") |
There was a problem hiding this comment.
This intent is for gboard, which doesn't come pre-installed in every watch (e.g. samsung watches).
This component would need to check if the intent exists, if it doesn't, we would need to think on a good behavior, e.g. call RemoteInputIntentHelper.startActivityForResult or let the user of the component provide the fallback behavior?
There was a problem hiding this comment.
Ah I didn't know, maybe providing some callback would be good? No strong opinions on how best to handle this from my side. Is this maybe a UX question perhaps? :)
| }, | ||
| value = value, | ||
| onValueChange = {}, | ||
| enabled = false, |
There was a problem hiding this comment.
What was not working before disabling the component?
Thank you for checking this out and giving valuable feedback 🙏 Currently very in draft stage. I can provide a video on how it's working now. From what I understood in the issue we want to have a wrapper on |
|
I think maybe I'll close this for now until we get a bit more input from the UX. Not quite sure how this component should work to provide most value to the users |
|
Thanks for the patience, Odin. I will ping you here once I get more information. |
WHAT
Adding NonEditableBasicTextField composable to open the keyboard on click.
Currently a draft as I need to get it to work. Opening a draft PR here so I can get some feedback on the solution :)
WHY
Ref. #1563
HOW
Checklist 📋