sentry/iouring: return 0 instead of -1 for toSubmit=0#13522
Open
TristanInSec wants to merge 1 commit into
Open
sentry/iouring: return 0 instead of -1 for toSubmit=0#13522TristanInSec wants to merge 1 commit into
TristanInSec wants to merge 1 commit into
Conversation
io_uring_enter with toSubmit=0 returns uintptr(-1) with a nil error. The syscall dispatch writes -1 directly to RAX on the nil-error path, which userspace libc interprets as EPERM. This is a valid and common call pattern: io_uring_wait_cqe() calls io_uring_enter(fd, 0, 1, IORING_ENTER_GETEVENTS) to wait for completions without submitting new work. Linux returns 0 for this case. Return 0 to indicate success when no submissions were requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io_uring_enterwithtoSubmit=0returnsuintptr(-1)with a nil error. The syscall dispatch writes -1 directly to RAX on the nil-error path, which userspace libc interprets as EPERM.This is a valid and common call pattern:
io_uring_wait_cqe()callsio_uring_enter(fd, 0, 1, IORING_ENTER_GETEVENTS)to wait for completions without submitting new work. Linux returns 0 for this case.Returns 0 to indicate success when no submissions were requested.