sentry/overlay: use fs.creds for upper layer rename#13520
Open
TristanInSec wants to merge 1 commit into
Open
Conversation
RenameAt passes the caller's credentials (rp.Credentials()) to the upper layer VFS rename, while all other upper layer mutations (CreateWhiteout, SetXattrAt, UnlinkAt, copy-up) consistently use the overlay creator's credentials (fs.creds). Linux overlayfs uses override_creds() with the mounter's credentials for all upper layer operations including rename. Use fs.creds to match both the Linux behavior and the pattern used by every other upper layer operation in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RenameAt passes the caller's credentials (rp.Credentials()) to the
upper layer VFS rename, while all other upper layer mutations
(CreateWhiteout, SetXattrAt, UnlinkAt, copy-up) consistently use
the overlay creator's credentials (fs.creds).
Linux overlayfs uses override_creds() with the mounter's credentials
for all upper layer operations including rename.
Use fs.creds to match both the Linux behavior and the pattern used
by every other upper layer operation in this file.