Fix runsc command in installation instructions#12556
Open
99991 wants to merge 1 commit intogoogle:masterfrom
Open
Fix runsc command in installation instructions#1255699991 wants to merge 1 commit intogoogle:masterfrom
99991 wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
The command just before moves it into I'd recommend having this as |
Collaborator
|
Please squash your commits: https://github.com/google/gvisor/blob/master/CONTRIBUTING.md?plain=1#L95-L99 |
`/usr/local/bin/runsc install` fails with "Permission denied" error. The more comprehensive [Docker Quick Start](https://gvisor.dev/docs/user_guide/quick_start/docker/) guide recommends `sudo runsc install` instead. @EtiennePerot recommends to specify the full path of `runsc` to avoid accidentally using the wrong binary. Also removed unnecessary `$` signs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installation instructions for gVisor contain the line
/usr/local/bin/runsc install, which fails with "Permission denied" error. The more comprehensive Docker Quick Start guide recommendssudo runsc installinstead.Also removed unnecessary
$signs.