Do not close processors during save, but instead close during restore. #12197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl813318410
branch
from
f47908e to
ce40255
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test/cl813318410
branch
2 times, most recently
from
268ff61 to
6282225
Compare
Before this change, the processors were closed in beforeSave which caused the packet processing for established connections to stop even in the case of save/resume. Do not close in beforeSave, instead close these processors in afterLoad for restore. PiperOrigin-RevId: 821714849
copybara-service
bot
force-pushed
the
test/cl813318410
branch
from
6282225 to
df97ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close processors during save, but instead close during restore.
Before this change, the processors were closed in beforeSave which caused the
packet processing for established connections to stop even in the case of
save/resume. Do not close in beforeSave, instead close these processors in
afterLoad for restore.