Drop unnecessary size checks and corrections for Netlink attributes. #11888
+6
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl778632075
branch
from
8f24e9d to
cbde1c3
Compare
copybara-service
bot
force-pushed
the
test/cl778632075
branch
from
cbde1c3 to
0bc829e
Compare
Some Netlink attributes have a fixed size. The map attempted to make adding attributes safer and easier by having default sizes for certain attributes. However, attributes are identified via their enums, which often overlap for different types of requests, making these default sizes not hold true for all attributes that map to it. PiperOrigin-RevId: 783458930
copybara-service
bot
force-pushed
the
test/cl778632075
branch
from
0bc829e to
7da1254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop unnecessary size checks and corrections for Netlink attributes.
Some Netlink attributes have a fixed size. The map attempted to make adding
attributes safer and easier by having default sizes for certain attributes.
However, attributes are identified via their enums, which often overlap for
different types of requests, making these default sizes not hold true for all
attributes that map to it.