Skip to content

Commit

Permalink
Rename existing GPU tests to GPU *smoke* tests.
Browse files Browse the repository at this point in the history
This is their current function, and it is useful to have smoke tests for
the gVisor release pipeline.

GPU tests that aren't of the "hello world" variety require multi-GiB
images and longer time to run, so we need to have them as separate
targets so that they can be run separately from the smoke tests.

PiperOrigin-RevId: 587187005
  • Loading branch information
EtiennePerot authored and gvisor-bot committed Dec 2, 2023
1 parent 326e168 commit 8042c6f
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 18 deletions.
4 changes: 2 additions & 2 deletions .buildkite/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,14 +174,14 @@ steps:
label: ":firefighter: GPU Smoke Test"
commands:
- make sudo TARGETS=//tools/gpu:main ARGS="install --latest" || cat /var/log/nvidia-installer.log
- make gpu-tests RUNTIME_ARGS="--strace --debug"
- make gpu-smoke-tests RUNTIME_ARGS="--strace --debug"
agents:
queue: gpu
- <<: *common
<<: *source_test_continuous
label: ":female_supervillain: COS GPU Smoke Test"
commands:
- make cos-gpu-tests RUNTIME_ARGS="--strace --debug"
- make cos-gpu-smoke-tests RUNTIME_ARGS="--strace --debug"
agents:
queue: cos-canary-gpu
- <<: *common
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ steps:
- <<: *common
label: ":female_supervillain: COS GPU Smoke Test"
commands:
- make cos-gpu-tests RUNTIME_ARGS="--strace --debug"
- make cos-gpu-smoke-tests RUNTIME_ARGS="--strace --debug"
agents:
queue: cos-canary-gpu
- <<: *common
Expand Down
22 changes: 11 additions & 11 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -273,17 +273,17 @@ arm-qemu-smoke-test: $(RUNTIME_BIN) load-arm-qemu
simple-tests: unit-tests # Compatibility target.
.PHONY: simple-tests

gpu-tests: load-basic_cuda-vector-add load-gpu_cuda-tests $(RUNTIME_BIN)
@$(call test,--test_env=RUNTIME=runc //test/gpu:gpu_test)
@$(call install_runtime,$(RUNTIME),--platform=systrap --nvproxy=true --nvproxy-docker=true)
@$(call sudo,test/gpu:gpu_test,--runtime=$(RUNTIME) -test.v $(ARGS))
.PHONY: gpu-tests

cos-gpu-tests: load-basic_cuda-vector-add load-gpu_cuda-tests $(RUNTIME_BIN)
@$(call sudo,test/gpu:gpu_test,--runtime=runc -test.v --cos-gpu $(ARGS))
@$(call install_runtime,$(RUNTIME),--platform=systrap --nvproxy=true)
@$(call sudo,test/gpu:gpu_test,--runtime=$(RUNTIME) -test.v --cos-gpu $(ARGS))
.PHONY: cos-gpu-tests
gpu-smoke-tests: load-basic_cuda-vector-add load-gpu_cuda-tests $(RUNTIME_BIN)
@$(call test,--test_env=RUNTIME=runc //test/gpu:gpu_smoke_test)
@$(call install_runtime,$(RUNTIME),--nvproxy=true --nvproxy-docker=true)
@$(call sudo,test/gpu:gpu_smoke_test,--runtime=$(RUNTIME) -test.v $(ARGS))
.PHONY: gpu-smoke-tests

cos-gpu-smoke-tests: load-basic_cuda-vector-add load-gpu_cuda-tests $(RUNTIME_BIN)
@$(call sudo,test/gpu:gpu_smoke_test,--runtime=runc -test.v --cos-gpu $(ARGS))
@$(call install_runtime,$(RUNTIME),--nvproxy=true)
@$(call sudo,test/gpu:gpu_smoke_test,--runtime=$(RUNTIME) -test.v --cos-gpu $(ARGS))
.PHONY: cos-gpu-smoke-tests

portforward-tests: load-basic_redis load-basic_nginx $(RUNTIME_BIN)
@$(call install_runtime,$(RUNTIME),--network=sandbox)
Expand Down
4 changes: 2 additions & 2 deletions test/gpu/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ package(
)

go_test(
name = "gpu_test",
srcs = ["gpu_test.go"],
name = "gpu_smoke_test",
srcs = ["gpu_smoke_test.go"],
tags = [
"local",
"noguitar",
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions tools/gpu/all_drivers_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ read -r -a versions <<< "$(cat "${tmp_file}")"

for driver in "${versions[@]}"; do
make sudo TARGETS=tools/gpu:main ARGS="install --version ${driver}"
make gpu-tests
done
make gpu-smoke-tests
done

0 comments on commit 8042c6f

Please sign in to comment.