Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's internationalization by introducing support for Thai and Lao languages. The changes involve adding comprehensive string resources for both languages and making them selectable in the user settings, thereby broadening the application's reach to a larger global audience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for Thai and Lao languages by introducing new string resource files and updating existing ones. While the initiative is great, the implementation has some critical issues. The Thai resource file (values-th/strings.xml) contains a significant number of strings that are incorrectly translated into Lao, which needs to be fixed. Additionally, both new resource files have an incorrect copyright year, and the Lao file contains some untranslated strings. There are also minor formatting inconsistencies in the new files that should be addressed for maintainability.
Note: Security Review has been skipped due to the limited scope of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3591 +/- ##
============================================
- Coverage 71.11% 71.07% -0.04%
+ Complexity 1629 1628 -1
============================================
Files 338 338
Lines 9114 9114
Branches 1003 1003
============================================
- Hits 6481 6478 -3
- Misses 2031 2034 +3
Partials 602 602 🚀 New features to boost your workflow:
|
shobhitagarwal1612
left a comment
There was a problem hiding this comment.
LGTM. Please address all comments by Gemini bot before submitting.
|
updated the files with the correct translations, so it's now ready to merge |
Fixes #3546
This PR adds the string resources for these 2 languages and the possibility to choose them in the settings page
Screen_recording_20260304_110946.webm
@shobhitagarwal1612 PTAL?