Skip to content

Commit 21f2948

Browse files
cramertjcopybara-github
authored andcommitted
Stop getting googletest::Result from the prelude
The prelude's inclusion of googletest::Result is confusing as it shadow's the standard library's Result type without a visible import. This is a first step towards removing googletest::Result from the prelude. PiperOrigin-RevId: 714850312
1 parent 7a54871 commit 21f2948

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+171
-93
lines changed

googletest/src/description.rs

+1
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ impl<T: Into<Cow<'static, str>>> From<T> for Description {
260260
mod tests {
261261
use super::Description;
262262
use crate::prelude::*;
263+
use crate::Result;
263264
use indoc::indoc;
264265

265266
#[test]

googletest/src/fixtures.rs

+1
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ mod tests {
144144
use crate as googletest;
145145
use crate::prelude::*;
146146
use crate::test;
147+
use crate::Result;
147148

148149
#[test]
149150
fn fixture_no_fixture() -> Result<()> {

googletest/src/internal/description_renderer.rs

+1
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ enum Decoration {
278278
mod tests {
279279
use super::{Block, Fragment, List};
280280
use crate::prelude::*;
281+
use crate::Result;
281282
use indoc::indoc;
282283

283284
#[test]

googletest/src/matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,7 @@ impl<T: Debug + Copy, M: Matcher<T>> Matcher<T> for &M {
310310
#[cfg(test)]
311311
mod tests {
312312
use crate::prelude::*;
313+
use crate::Result;
313314

314315
#[test]
315316
fn ref_matchers_can_be_reused() -> Result<()> {

googletest/src/matcher_support/auto_eq.rs

+1
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ pub mod internal {
8787
#[cfg(test)]
8888
mod tests {
8989
use crate::prelude::*;
90+
use crate::Result;
9091

9192
#[test]
9293
fn auto_ref_matcher() -> Result<()> {

googletest/src/matcher_support/count_elements.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ pub(crate) fn count_elements<ContainerT: IntoIterator>(value: ContainerT) -> usi
3030

3131
#[cfg(test)]
3232
mod tests {
33-
3433
use super::*;
3534
use crate::prelude::*;
35+
use crate::Result;
3636

3737
#[test]
3838
fn count_elements_vec() -> Result<()> {

googletest/src/matcher_support/edit_distance.rs

+1
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ impl<T: Clone> Path<T> {
284284
mod tests {
285285
use super::*;
286286
use crate::prelude::*;
287+
use crate::Result;
287288
use quickcheck::{quickcheck, Arbitrary, TestResult};
288289

289290
#[test]

googletest/src/matcher_support/summarize_diff.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ impl SummaryBuilder {
433433
#[cfg(test)]
434434
mod tests {
435435
use super::*;
436-
use crate::{matcher_support::edit_distance::Mode, prelude::*};
436+
use crate::{matcher_support::edit_distance::Mode, prelude::*, Result};
437437
use indoc::indoc;
438438
use std::fmt::Write;
439439

googletest/src/matchers/all_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ macro_rules! __all {
8686
mod tests {
8787
use crate::matcher::MatcherResult;
8888
use crate::prelude::*;
89+
use crate::Result;
8990
use indoc::indoc;
9091

9192
#[test]

googletest/src/matchers/any_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ macro_rules! __any {
8888
mod tests {
8989
use crate::matcher::MatcherResult;
9090
use crate::prelude::*;
91+
use crate::Result;
9192
use indoc::indoc;
9293

9394
#[test]

googletest/src/matchers/anything_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ impl<T: Debug + Copy> Matcher<T> for Anything {
5555
#[cfg(test)]
5656
mod tests {
5757
use crate::prelude::*;
58+
use crate::Result;
5859

5960
#[test]
6061
fn anything_matches_i32() -> Result<()> {

googletest/src/matchers/bool_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ impl<'a> Matcher<&'a bool> for BoolMatcher {
6969
mod tests {
7070
use super::*;
7171
use crate::prelude::*;
72+
use crate::Result;
7273

7374
#[test]
7475
fn match_value() -> Result<()> {

googletest/src/matchers/char_count_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ mod tests {
101101
use crate::description::Description;
102102
use crate::matcher::MatcherResult;
103103
use crate::prelude::*;
104+
use crate::Result;
104105
use indoc::indoc;
105106
use std::fmt::Debug;
106107

googletest/src/matchers/conjunction_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ impl<T: Debug + Copy, M1: Matcher<T>, M2: Matcher<T>> Matcher<T> for Conjunction
104104
#[cfg(test)]
105105
mod tests {
106106
use crate::prelude::*;
107+
use crate::Result;
107108
use indoc::indoc;
108109

109110
#[test]

googletest/src/matchers/container_eq_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,7 @@ where
255255
mod tests {
256256
use crate::matcher::MatcherResult;
257257
use crate::prelude::*;
258+
use crate::Result;
258259
use indoc::indoc;
259260
use std::collections::HashSet;
260261

googletest/src/matchers/contains_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ impl<InnerMatcherT> ContainsMatcher<InnerMatcherT> {
159159
mod tests {
160160
use crate::matcher::MatcherResult;
161161
use crate::prelude::*;
162+
use crate::Result;
162163

163164
#[test]
164165
fn contains_matches_singleton_slice_with_value() -> Result<()> {

googletest/src/matchers/contains_regex_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ impl<ActualT: AsRef<str> + Debug + Copy> Matcher<ActualT> for ContainsRegexMatch
8282
mod tests {
8383
use crate::matcher::MatcherResult;
8484
use crate::prelude::*;
85+
use crate::Result;
8586

8687
#[test]
8788
fn contains_regex_matches_string_reference_with_pattern() -> Result<()> {

googletest/src/matchers/derefs_to_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ mod tests {
6363
use std::rc::Rc;
6464

6565
use crate::prelude::*;
66+
use crate::Result;
6667
use indoc::indoc;
6768

6869
#[test]

googletest/src/matchers/disjunction_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ impl<T: Debug + Copy, M1: Matcher<T>, M2: Matcher<T>> Matcher<T> for Disjunction
9898
#[cfg(test)]
9999
mod tests {
100100
use crate::prelude::*;
101+
use crate::Result;
101102
use indoc::indoc;
102103

103104
#[test]

googletest/src/matchers/display_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ impl<T: Debug + Display + Copy, InnerMatcher: for<'a> Matcher<&'a str>> Matcher<
6767
#[cfg(test)]
6868
mod tests {
6969
use crate::prelude::*;
70+
use crate::Result;
7071
use indoc::indoc;
7172
use std::fmt::{Debug, Display, Error, Formatter};
7273

googletest/src/matchers/each_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ where
119119
#[cfg(test)]
120120
mod tests {
121121
use crate::prelude::*;
122+
use crate::Result;
122123
use indoc::indoc;
123124
use std::collections::HashSet;
124125

googletest/src/matchers/empty_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ where
6161
#[cfg(test)]
6262
mod tests {
6363
use crate::prelude::*;
64+
use crate::Result;
6465
use std::collections::HashSet;
6566

6667
#[test]

googletest/src/matchers/eq_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ fn to_display_output(string: &str) -> Option<String> {
138138
#[cfg(test)]
139139
mod tests {
140140
use crate::prelude::*;
141+
use crate::Result;
141142
use indoc::indoc;
142143

143144
#[test]

googletest/src/matchers/err_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ impl<'a, T: Debug, E: Debug, InnerMatcherT: Matcher<&'a E>> Matcher<&'a std::res
111111
mod tests {
112112
use crate::matcher::MatcherResult;
113113
use crate::prelude::*;
114+
use crate::Result;
114115
use indoc::indoc;
115116

116117
#[test]

googletest/src/matchers/ge_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ impl<ActualT: Debug + PartialOrd<ExpectedT> + Copy, ExpectedT: Debug> Matcher<Ac
104104
mod tests {
105105
use crate::matcher::MatcherResult;
106106
use crate::prelude::*;
107+
use crate::Result;
107108
use indoc::indoc;
108109
use std::ffi::OsString;
109110

googletest/src/matchers/gt_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ impl<ActualT: Debug + PartialOrd<ExpectedT> + Copy, ExpectedT: Debug> Matcher<Ac
104104
mod tests {
105105
use crate::matcher::MatcherResult;
106106
use crate::prelude::*;
107+
use crate::Result;
107108
use indoc::indoc;
108109
use std::ffi::OsString;
109110

googletest/src/matchers/has_entry_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ impl<'a, KeyT: Debug + Eq + Hash, ValueT: Debug, MatcherT: Matcher<&'a ValueT>>
114114
#[cfg(test)]
115115
mod tests {
116116
use crate::prelude::*;
117+
use crate::Result;
117118
use indoc::indoc;
118119
use std::collections::HashMap;
119120

googletest/src/matchers/is_encoded_string_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ where
100100
mod tests {
101101
use crate::matcher::MatcherResult;
102102
use crate::prelude::*;
103+
use crate::Result;
103104

104105
#[test]
105106
fn matches_string_as_byte_slice() -> Result<()> {

googletest/src/matchers/is_nan_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ impl<T: Float + Debug + Copy> Matcher<T> for IsNanMatcher {
4040
#[cfg(test)]
4141
mod tests {
4242
use crate::prelude::*;
43+
use crate::Result;
4344

4445
#[test]
4546
fn matches_f32_nan() -> Result<()> {

googletest/src/matchers/le_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ impl<ActualT: Debug + PartialOrd<ExpectedT> + Copy, ExpectedT: Debug> Matcher<Ac
102102
mod tests {
103103
use crate::matcher::MatcherResult;
104104
use crate::prelude::*;
105+
use crate::Result;
105106
use indoc::indoc;
106107
use std::ffi::OsString;
107108

googletest/src/matchers/len_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ mod tests {
8989
use crate::description::Description;
9090
use crate::matcher::MatcherResult;
9191
use crate::prelude::*;
92+
use crate::Result;
9293
use indoc::indoc;
9394
use std::collections::{
9495
BTreeMap, BTreeSet, BinaryHeap, HashMap, HashSet, LinkedList, VecDeque,

googletest/src/matchers/lt_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ impl<ActualT: Debug + PartialOrd<ExpectedT> + Copy, ExpectedT: Debug> Matcher<Ac
104104
mod tests {
105105
use crate::matcher::MatcherResult;
106106
use crate::prelude::*;
107+
use crate::Result;
107108
use indoc::indoc;
108109
use std::ffi::OsString;
109110

googletest/src/matchers/matches_regex_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ where
103103
mod tests {
104104
use crate::matcher::MatcherResult;
105105
use crate::prelude::*;
106+
use crate::Result;
106107

107108
#[test]
108109
fn matches_regex_matches_string_reference_with_pattern() -> Result<()> {

googletest/src/matchers/near_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ impl<T: Debug + Float + Copy> Matcher<T> for NearMatcher<T> {
198198
mod tests {
199199
use crate::matcher::MatcherResult;
200200
use crate::prelude::*;
201+
use crate::Result;
201202

202203
#[test]
203204
fn matches_value_inside_range() -> Result<()> {

googletest/src/matchers/none_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ impl<'a, T: Debug> Matcher<&'a Option<T>> for NoneMatcher {
6868
mod tests {
6969
use crate::matcher::MatcherResult;
7070
use crate::prelude::*;
71+
use crate::Result;
7172

7273
#[test]
7374
fn none_matches_option_with_none() -> Result<()> {

googletest/src/matchers/not_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ impl<T: Debug + Copy, InnerMatcherT: Matcher<T>> Matcher<T> for NotMatcher<Inner
6767
mod tests {
6868
use crate::matcher::MatcherResult;
6969
use crate::prelude::*;
70+
use crate::Result;
7071
use indoc::indoc;
7172

7273
#[test]

googletest/src/matchers/ok_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ impl<'a, T: Debug, E: Debug, InnerMatcherT: Matcher<&'a T>> Matcher<&'a std::res
115115
mod tests {
116116
use crate::matcher::MatcherResult;
117117
use crate::prelude::*;
118+
use crate::Result;
118119
use indoc::indoc;
119120

120121
#[test]

googletest/src/matchers/points_to_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ where
6363
#[cfg(test)]
6464
mod tests {
6565
use crate::prelude::*;
66+
use crate::Result;
6667
use indoc::indoc;
6768

6869
#[test]

googletest/src/matchers/predicate_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ where
149149
#[cfg(test)]
150150
mod tests {
151151
use crate::prelude::*;
152+
use crate::Result;
152153

153154
// Simple matcher with a description
154155
fn is_odd() -> impl Matcher<i32> {

googletest/src/matchers/result_of_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ pub mod internal {
164164
#[cfg(test)]
165165
mod tests {
166166
use crate::prelude::*;
167+
use crate::Result;
167168
use indoc::indoc;
168169

169170
#[test]

googletest/src/matchers/some_matcher.rs

+1
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ impl<'a, T: Debug, InnerMatcherT: Matcher<&'a T>> Matcher<&'a Option<T>>
109109
mod tests {
110110
use crate::matcher::MatcherResult;
111111
use crate::prelude::*;
112+
use crate::Result;
112113
use indoc::indoc;
113114

114115
#[test]

0 commit comments

Comments
 (0)