Add CLI flag to disable modifier reordering#1388
Merged
Merged
Conversation
The library API already supports `JavaFormatterOptions.reorderModifiers(false)`, but the CLI had no equivalent flag. This change adds `--skip-reordering-modifiers` and wires it through the CLI into `JavaFormatterOptions`. The default CLI behavior is unchanged. Fixes #1373 COPYBARA_INTEGRATE_REVIEW=#1373 from mkurz:cli-skip-reordering-modifiers ef826a7 PiperOrigin-RevId: 917231420
copybara-service
Bot
force-pushed
the
test_917226990
branch
from
ee6f9ee to
6bbd4a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CLI flag to disable modifier reordering
The library API already supports
JavaFormatterOptions.reorderModifiers(false), but the CLI had no equivalent flag.This change adds
--skip-reordering-modifiersand wires it through the CLI intoJavaFormatterOptions.The default CLI behavior is unchanged.
Fixes #1373
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1373 from mkurz:cli-skip-reordering-modifiers ef826a7