Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow diff context records to be adjusted #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IdlePhysicist
Copy link

This commit enables the number context records to be adjusted, allowing for greater readability in some debugging scenarios.

Closes #358

This commit enables the number context records to be adjusted, allowing
for greater readability in some debugging scenarios.

Closes google#358
@dsnet
Copy link
Collaborator

dsnet commented Feb 3, 2025

Hi, thanks for the contribution.

It's a known issue that the reporter does not print enough context for all use cases and this is something worth addressing, but I believe exposing the numContextRecords is too low-level of a implementation detail to expose. We probably want a single higher-level option to control the amount of printout, but it's unclear what that option should exactly be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add more context to Diff output?
2 participants