This repository was archived by the owner on Nov 5, 2022. It is now read-only.
Bug: UTF-32-LE misdetected as UTF-16-LE #472
Open
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the byte-order mark detector selects the the UTF-16-LE
encoding if the first two bytes of the stream are OxFF OxFE, without
checking to see if the next two bytes are null (which is the BOM for
UTF-32-LE).
Solution: check for the UTF-32 BOMs before checking for the UTF-16
marks.
Resolves #471