Generate better formatted Rust code#8919
Open
csmulhern wants to merge 2 commits intogoogle:masterfrom
Open
Conversation
Contributor
Author
|
@jtdavis777 it looks like you've been reviewing recent PRs for this project. I have a few more Rust style cleanups I would love to do. They aren't functional changes, so should be pretty straightforward to review. Can I send them your way? |
Collaborator
|
Sure I can add this to the docket. I am not a rust dev at all but am happy to look this over. |
Contributor
Author
|
Great, thank you! |
jtdavis777
reviewed
Feb 19, 2026
Collaborator
jtdavis777
left a comment
jtdavis777
left a comment
There was a problem hiding this comment.
Overall the changes to the generator code look good, I have two questions
| code_ += " }"; | ||
| code_ += " }"; | ||
| code_ += "}"; | ||
| code_ += ""; |
Collaborator
There was a problem hiding this comment.
curious why you have a function to do this, but also a bunch of new lines that don't use the function?
|
|
||
| const Namespace* CurrentNameSpace() const { return cur_name_space_; } | ||
|
|
||
| void AddLineBeforeContentIfNeeded() { code_ += ""; } |
Collaborator
There was a problem hiding this comment.
this function seems a little misnamed -- there is no check here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no behavioral changes in the PR. This simply updates the Rust generator to produce better formatted code, with the following changes:
modblocks is properly indented.#[inline]annotations have been moved below function documentation, which is the expected style.The first commit contains the relevant changes.
The second commit simply regenerates all the example code.
It would be easiest to review the commits separately.