⚠️[critical][fix][flatc] malfunction when flatc --java --grpc --java-package-prefix#8829
Open
eeoun wants to merge 3 commits intogoogle:masterfrom
Open
⚠️[critical][fix][flatc] malfunction when flatc --java --grpc --java-package-prefix#8829eeoun wants to merge 3 commits intogoogle:masterfrom
eeoun wants to merge 3 commits intogoogle:masterfrom
Conversation
eeoun
force-pushed
the
fix/java_grpc_package_prefix
branch
3 times, most recently
from
ed86221 to
0b1fe9c
Compare
eeoun
force-pushed
the
fix/java_grpc_package_prefix
branch
from
0b1fe9c to
5ce975f
Compare
eeoun
force-pushed
the
fix/java_grpc_package_prefix
branch
2 times, most recently
from
15c9fce to
d28b134
Compare
eeoun
changed the title
eeoun
force-pushed
the
fix/java_grpc_package_prefix
branch
from
d28b134 to
c2fd5ff
Compare
Collaborator
|
hey @eeoun ! Thank you for the excellent issue and pull request. I think the only thing that I would like to see added would be a regression test. |
eeoun
force-pushed
the
fix/java_grpc_package_prefix
branch
from
c8ec6cb to
c2fd5ff
Compare
…ix com.github.flatbuffers It may cause generated GRPC class not in correct package and reference Table class reference package path lack of prefix package
eeoun
force-pushed
the
fix/java_grpc_package_prefix
branch
from
c2fd5ff to
95e2f5b
Compare
Collaborator
|
@bjornharrtell is java also one of your languages? Would you be able to give this PR a once over? :D |
aardappel
reviewed
Dec 7, 2025
Collaborator
|
I guess |
Collaborator
|
@jtdavis777 I'm reasonably comfortable with Java yes, but I'm clueless about the grpc stuff and would like to remain so. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple fix of issue
#8827
Just test on my machine works fine.
Never test if have memory leaks. I've never write Cpp code before. Rewrite it if needed.