Skip to content

Fix: Actually call ValidateOptions #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aardappel merged 2 commits into from
Aug 12, 2025
Merged

Fix: Actually call ValidateOptions #8665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc8799d
fix: actually call ValidateOptions
jtdavis777 Aug 8, 2025
21f55e2
convert error to warning in validateoptions
jtdavis777 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/flatc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,8 @@ FlatCOptions FlatCompiler::ParseFromCommandLineArguments(int argc,
}
}

ValidateOptions(options);

return options;
}

Expand All @@ -766,9 +768,8 @@ void FlatCompiler::ValidateOptions(const FlatCOptions &options) {

if (!options.filenames.size()) Error("missing input files", false, true);

if (opts.proto_mode) {
if (options.any_generator)
Error("cannot generate code directly from .proto files", true);
if (opts.proto_mode && options.any_generator) {
Warn("cannot generate code directly from .proto files", true);
} else if (!options.any_generator && options.conform_to_schema.empty() &&
options.annotate_schema.empty()) {
Error("no options: specify at least one generator.", true);
Expand Down
Loading